psimsa/handlebars.js
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix weird error in integration tests

Browse Source 
somehow the variable "$i" gets overwritten in integration-testing/multi-nodejs-test/test.sh:20, which is why we now rename it to a more meaningful variable
This commit is contained in:
Nils Knappmeier
2021-02-15 09:50:16 +01:00
parent b6d3de7123
commit eb860c0899
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
integration-testing/multi-nodejs-test/test.sh
+8 -6
View File
@@ -12,18 +12,20 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
# However, the built distribution should work with older NodeJS versions as well. # However, the built distribution should work with older NodeJS versions as well.
# This test is simple by design. It merely ensures, that calling Handlebars does not fail with old versions. # This test is simple by design. It merely ensures, that calling Handlebars does not fail with old versions.
# It does (almost) not test for correctness, because that is already done in the mocha-tests. # It does (almost) not test for correctness, because that is already done in the mocha-tests.
# And it does not use any NodeJS based testing framwork to make this part independent of the Node version. # And it does not use any NodeJS based testing framework to make this part independent of the Node version.
unset npm_config_prefix unset npm_config_prefix
echo "Handlebars should be able to run in various versions of NodeJS" echo "Handlebars should be able to run in various versions of NodeJS"
for i in 0.10 0.12 4 5 6 7 8 9 10 11 12 13 ; do for node_version_to_test in 0.10 0.12 4 5 6 7 8 9 10 11 12 13 14 15; do
rm target node_modules package-lock.json -rf rm target node_modules package-lock.json -rf
mkdir target mkdir target
nvm install "$i"
nvm exec "$i" npm install nvm install "$node_version_to_test"
nvm exec "$i" npm run test nvm exec "$node_version_to_test" npm install
nvm exec "$i" npm run test-precompile nvm exec "$node_version_to_test" npm run test
nvm exec "$node_version_to_test" npm run test-precompile
echo Success echo Success
done done