From 6f1de2025ebe1ab5cdb52edde9887881acc54d2e Mon Sep 17 00:00:00 2001 From: Jakob Linskeseder Date: Wed, 18 Mar 2026 21:13:05 +0100 Subject: [PATCH] Explicitly set region for AWS S3 publishing Fixes the following error: `Error: Region is missing` --- .github/workflows/release.yml | 1 + tasks/publish-to-aws.js | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 12c7d9f8..5b709f6c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -34,5 +34,6 @@ jobs: npm run publish:aws env: S3_BUCKET_NAME: 'builds.handlebarsjs.com' + S3_REGION: 'us-east-1' S3_ACCESS_KEY_ID: ${{ secrets.S3_ACCESS_KEY_ID }} S3_SECRET_ACCESS_KEY: ${{ secrets.S3_SECRET_ACCESS_KEY }} diff --git a/tasks/publish-to-aws.js b/tasks/publish-to-aws.js index 804a9f0a..00cb9f69 100644 --- a/tasks/publish-to-aws.js +++ b/tasks/publish-to-aws.js @@ -35,10 +35,11 @@ async function main() { function validateS3Env() { const bucket = process.env.S3_BUCKET_NAME, + region = process.env.S3_REGION, key = process.env.S3_ACCESS_KEY_ID, secret = process.env.S3_SECRET_ACCESS_KEY; - if (!bucket || !key || !secret) { + if (!bucket || !region || !key || !secret) { throw new Error('Missing S3 config values'); } } @@ -79,6 +80,7 @@ async function uploadToBucket(localFile, nameInBucket) { function getS3Client() { if (!s3Client) { s3Client = new S3({ + region: process.env.S3_REGION, credentials: { accessKeyId: process.env.S3_ACCESS_KEY_ID, secretAccessKey: process.env.S3_SECRET_ACCESS_KEY,