From 2b3fdf7ea80bb7af8e6317c2ce30a4ce3236e7f6 Mon Sep 17 00:00:00 2001
From: kpdecker <kpdecker@gmail.com>
Date: Sat, 23 Aug 2014 18:52:30 -0500
Subject: [PATCH] Additional test coverage cleanup

Also fixes the template._child implementation which broke with the depthed work.
---
 lib/handlebars/compiler/printer.js |  6 ++----
 lib/handlebars/runtime.js          |  7 +++----
 spec/precompiler.js                | 19 ++++++++++++++++++-
 spec/runtime.js                    | 20 ++++++++++++++++++++
 4 files changed, 43 insertions(+), 9 deletions(-)

diff --git a/lib/handlebars/compiler/printer.js b/lib/handlebars/compiler/printer.js
index be66d73d..7654245c 100644
--- a/lib/handlebars/compiler/printer.js
+++ b/lib/handlebars/compiler/printer.js
@@ -10,16 +10,14 @@ export function PrintVisitor() {
 
 PrintVisitor.prototype = new Visitor();
 
-PrintVisitor.prototype.pad = function(string, newline) {
+PrintVisitor.prototype.pad = function(string) {
   var out = "";
 
   for(var i=0,l=this.padding; i<l; i++) {
     out = out + "  ";
   }
 
-  out = out + string;
-
-  if(newline !== false) { out = out + "\n"; }
+  out = out + string + "\n";
   return out;
 };
 
diff --git a/lib/handlebars/runtime.js b/lib/handlebars/runtime.js
index 0780fbf6..eb942d55 100644
--- a/lib/handlebars/runtime.js
+++ b/lib/handlebars/runtime.js
@@ -150,12 +150,11 @@ export function template(templateSpec, env) {
   };
 
   ret._child = function(i) {
-    if (templateSpec.depth) {
-      throw new Exception('_child can not be used with depthed methods');
+    if (templateSpec.useDepths) {
+      throw new Exception('_child can not be used with depthed templates');
     }
 
-    // TODO : Fix this
-    return container.programWithDepth(i);
+    return program(container, i, templateSpec[i]);
   };
   return ret;
 }
diff --git a/spec/precompiler.js b/spec/precompiler.js
index 3b66353a..0310681c 100644
--- a/spec/precompiler.js
+++ b/spec/precompiler.js
@@ -1,5 +1,7 @@
 /*global shouldThrow */
 
+var uglify = require('uglify-js');
+
 describe('precompiler', function() {
   // NOP Under non-node environments
   if (typeof process === 'undefined') {
@@ -12,10 +14,13 @@ describe('precompiler', function() {
   var log,
       logFunction,
 
-      precompile;
+      precompile,
+      minify;
 
   beforeEach(function() {
     precompile = Handlebars.precompile;
+    minify = uglify.minify;
+
     logFunction = console.log;
     log = '';
     console.log = function() {
@@ -24,6 +29,7 @@ describe('precompiler', function() {
   });
   afterEach(function() {
     Handlebars.precompile = precompile;
+    uglify.minify = minify;
     console.log = logFunction;
   });
 
@@ -65,6 +71,10 @@ describe('precompiler', function() {
     equal(/'empty'/.test(log), true);
     equal(/'example_1'/.test(log), true);
   });
+  it('should protect from regexp patterns', function() {
+    Precompiler.cli({templates: [__dirname + '/artifacts'], extension: 'hb(s'});
+    // Success is not throwing
+  });
   it('should output simple templates', function() {
     Handlebars.precompile = function() { return 'simple'; };
     Precompiler.cli({templates: [__dirname + '/artifacts/empty.handlebars'], simple: true, extension: 'handlebars'});
@@ -110,4 +120,11 @@ describe('precompiler', function() {
     Precompiler.cli({templates: [__dirname + '/artifacts/empty.handlebars'], simple: true, extension: 'handlebars', known: 'foo'});
     equal(log, 'simple\n');
   });
+
+  it('should output minimized templates', function() {
+    Handlebars.precompile = function() { return 'amd'; };
+    uglify.minify = function() { return {code: 'min'}; };
+    Precompiler.cli({templates: [__dirname + '/artifacts/empty.handlebars'], min: true, extension: 'handlebars'});
+    equal(log, 'min');
+  });
 });
diff --git a/spec/runtime.js b/spec/runtime.js
index 4431a687..dc6e5126 100644
--- a/spec/runtime.js
+++ b/spec/runtime.js
@@ -33,4 +33,24 @@ describe('runtime', function() {
       }, Error, /Template was precompiled with an older version of Handlebars than the current runtime/);
     });
   });
+
+  describe('#child', function() {
+    if (!Handlebars.compile) {
+      return;
+    }
+
+    it('should throw for depthed methods', function() {
+      shouldThrow(function() {
+        var template = Handlebars.compile('{{#foo}}{{../bar}}{{/foo}}');
+        template._setup({});
+        template._setup({});
+        template._child(1);
+      }, Error, '_child can not be used with depthed templates');
+    });
+    it('should expose child template', function() {
+      var template = Handlebars.compile('{{#foo}}bar{{/foo}}');
+      equal(template._child(1)(), 'bar');
+      equal(template._child(1)(), 'bar');
+    });
+  });
 });